Details
Minor
Description
The property SLF4JLogPrependSessionID "Controls whether session ID is prepended to log message." This property is passed down to SLF4J and used in the method quickfix.SLF4JLog#getLogger.
Based on the property name and description, one would think that the Session ID will appear as prefix of category. But the method getLogger suffixes category with session ID instead of prefixing it. I think this is a bug.
Bug:
private Logger getLogger(SessionID sessionID, String category, String defaultCategory, String logPrefix) { return LoggerFactory.getLogger((category != null ? substituteVariables(sessionID, category) : defaultCategory) + logPrefix); }
Proposed Fix:
private Logger getLogger(SessionID sessionID, String category, String defaultCategory, String logPrefix) { return LoggerFactory.getLogger(logPrefix + (category != null ? substituteVariables(sessionID, category) : defaultCategory)); }
Thanks!