Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-965

Regression when using non-default charset

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Default
          • Resolution: Fixed
          • Affects Version/s: 2.1.0
          • Fix Version/s: 2.1.1
          • Component/s: Engine
          • Labels:
            None

            Description

            The optimizations in commit 6229d0722d8c6f6e7b2b251772a92caf2f4bdc25 cause a regression where using fields with a non-default charset such as UTF-8 causes message corruption (even if the charset is properly set via CharsetSupport.setCharset()).

            Further, the test that caught this regression (MessageTest.testMessageWithEncodedField via its helper method) was modified in the same commit to work around the test failure, so that the test passes but the bug still occurs in real applications..

            I will submit a PR shortly with a fix.

              Attachments

                Activity

                  People

                  • Assignee:
                    amichair amichair
                    Reporter:
                    amichair amichair
                  • Votes:
                    0 Vote for this issue
                    Watchers:
                    2 Start watching this issue

                    Dates

                    • Created:
                      Updated:
                      Resolved: