Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-524

Session responder lock fix for QFJ-421 got reverted in SVN

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Default
    • Resolution: Duplicate
    • Affects Version/s: None
    • Fix Version/s: 1.5.1
    • Component/s: Engine
    • Labels:
      None

      Description

      The one-line fix for QFJ-421 in Mar 2009 (r921) seems to have been accidentally reverted in Jan 2010 by r928.

      Why not use an idiom such as:

      private final Object responderSync = new byte[0];

      Others may prefer simply a new Object() for a lock like this. I think the debate[1] over bytecode size or whatever is moot, but clearly a String was a bad choice here for maintainability reasons, i.e. it just looks like a constant value suitable to be interned.

      [1] http://java.itags.org/java-core-apis/32998/ "Java Core APIs: locks: Object versus empty byte array"

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              seh4nc Scott Harrington
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: