Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Trivial
-
Resolution: Fixed
-
Affects Version/s: 1.1.0
-
Fix Version/s: 1.2.1
-
Component/s: Metadata/Specs
-
Labels:None
Description
isMsgField uses single & after a null check - since & doesn't short circuit it throws null pointer if fields is null.
Change from:
public boolean isMsgField(String msgType, int field) {
Set fields = (Set) messageFields.get(msgType);
return fields != null & fields.contains(new Integer(field));
}
to
public boolean isMsgField(String msgType, int field) {
Set fields = (Set) messageFields.get(msgType);
return fields != null && fields.contains(new Integer(field));
}
Unit test - add the following to DataDictionaryTest.testDictionary()
assertFalse(dd.isMsgField("UNKNOWN_TYPE", 1));
Change from:
public boolean isMsgField(String msgType, int field) {
Set fields = (Set) messageFields.get(msgType);
return fields != null & fields.contains(new Integer(field));
}
to
public boolean isMsgField(String msgType, int field) {
Set fields = (Set) messageFields.get(msgType);
return fields != null && fields.contains(new Integer(field));
}
Unit test - add the following to DataDictionaryTest.testDictionary()
assertFalse(dd.isMsgField("UNKNOWN_TYPE", 1));
Activity
- All
- Comments
- History
- Activity
- Subversion Commits
- Builds
Hide
Brad Harvey
added a comment - 21/Jun/07 10:14 AM
Credit for the catch goes to IntelliJ IDEA's code analysis 
Show
Brad Harvey
added a comment - 21/Jun/07 10:14 AM Credit for the catch goes to IntelliJ IDEA's code analysis
Great catch, Brad!
fixed in rev 684