Improvement to session settings (multibyte)

Hi all!

I work as an engineer in a local trading software company in Taiwan.
In our solution for outbound trading, we use QuickFIX/J for
communication with FIX gateways. It works fine for us most of the time,
thanks for the great work, developers!

I find some problems with weekly session in QuickFIX/J in our test
environment these days though:

1. I can't confiure a weekly session using SessionSettings with
an InputStream object (in my case, a FileInputStream object),
because SessionSettings doesn't work well with multibyte characters,
and the name of weekdays in our locale (zh-TW) is in multibyte
characters. Therefore I change the code to use InputStreamReader to read
characters instead.

2. When parsing name of weekdays in class DayConverter, only the leading
two characters are used for comparison, maybe for easier configuration.
But the leading two characters in our locale is all the same for the
7 weekdays, thus it always match the first one (Sunday).
I would suggest not just using the leading two characters for
comparison, it will still work fine for people using only two characters
to confiure.

3. Weekdays (StartDay, EndDay) is always in UTC, even when I set
TimeZone to our local one. For example:

TimeZone=Asia/Taipei
StartTime=06:45:00
EndTime=06:44:59

If I set both StartDay and EndDay to Wednesday (the equivalent,
localized one, in multibyte characters, of course
it would be a weekly session of from Wednesday 22:45:00 UTC
to Wednesday 22:44:59 UTC,
instead of from Tuesday 22:45:00 UTC to Tuesdasy 22:44:59 UTC.
(Note: Wednesday 06:45:00 in Taipei is Tuesday 22:45:00 UTC)

I made some changes to solve the 3 problems above in my own way,
the patch is attached with this mail.
Hope it can be adoped by our developers or help somebody else

Regards,
yongjhen

–
Yong-Jhen Hong ([email protected])
Senior Software Engineer
Financial Solution Dept.
ICE Technology Corp.
Taiwan