I think checking the data dictionary is a whole new topic. I guess we could check for the Sender/TargetCompID and only fail if CheckCompID=Y is set.
Would that be OK as a first step?

I'm adding a test case which fails on 1.5.3 if CheckCompID=M and TargetCompID isn't mandatory on dictionary. It shold pass after a fix.

I think the cleanest and less intrusive solution is to move SenderCompID/TargetCompID fields extraction from quickfix.Session#verify() to quickfix.Session#isCorrectCompID(), eg:
private boolean isCorrectCompID(Message message) throws FieldNotFound{
if (!checkCompID)

Header header = message.getHeader();
final String senderCompID = header.getString(SenderCompID.FIELD);
final String targetCompID = header.getString(TargetCompID.FIELD);
return sessionID.getSenderCompID().equals(targetCompID)
&& sessionID.getTargetCompID().equals(senderCompID);
}

Thoughts?

Sounds correct to me

Just out of curiosity: but you do have a "dummy" TargetCompID set in your session configuration that you remove on outgoing messages?

I do have TargetCompID set on initiator, but receiver doesn't seem to care much (they ignore it i suppose).

Committed as http://sourceforge.net/p/quickfixj/code/1137/
I have slightly simplified the unit test and proposed solution, hope that's OK for you.

Thanks Christoph.
1/ Test looks much neater
2/ isCorrectCompID() signature, to the extent of my familiarity with the QFJ API, would be more consistent with the rest of the checks if it accepted Message as a parameter (even though default implementation checks specifically header fields)

When are you planning 1.6.0 release? (i'm about to contribute another QFJ jira)

It is a private method so I did not really care about the signature. But you are right, there are more methods which accept the general Message as parameter. So I think I will change it then.

Re 1.6.0 release: there is no real date set at the moment. There are still some things open which IMHO are needed for completion and are planned for a long time (e.g. QFJ-499). You could either build your own snapshot from trunk or check out the 1.5 branch and apply your changes there if you need it earlier. Hope that's OK for you.