[QFJ-973] Provide configuration to turn off checksum validation Created: 20/Mar/19 Updated: 17/Jun/20 Resolved: 14/Aug/19 |
|
| Status: | Closed |
| Project: | QuickFIX/J |
| Component/s: | None |
| Affects Version/s: | 2.1.1 |
| Fix Version/s: | 2.2.0 |
| Type: | Improvement | Priority: | Default |
| Reporter: | Frank Peter Michler | Assignee: | Wojciech Zankowski |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Description |
|
Recently, I have experienced a QuickFIX/J based application ignoring or rejecting messages with an invalid checksum (depending on the setting of the RejectGarbledMessage property). On the other hand, these messages featured the required structure for further processing. So I have decided to provide an enhancement which allows the FIX Engine to process messages with invalid checksum as ordinary messages having passed validation. This enhancement will be provided as a configuration option controlled by the property ProcessMessageWithInvalidChecksum. By default, this property will be set to 'N' such that Messages with invalid checksum will be either ignored or rejected as before. In particular, it will only be possible to set either RejectGarbledMessage or ProcessMessageWithInvalidChecksum to 'Y' for a specific session. If both properties are set to 'Y' at once, a ConfigError will be thrown. |
| Comments |
| Comment by Christoph John [ 08/Jul/19 ] |
|
Hi, |
| Comment by Frank Peter Michler [ 08/Jul/19 ] |
|
Hi Christoph, currently I do not have time to work on this task. So can I do the pull request when I start to do so? I assume that the pull request has to be done via github. In addition, can you also tell me how to assign this Task to myself? Best regards, Frank |
| Comment by Christoph John [ 08/Jul/19 ] |
|
Hi Frank, oh sorry. I thought you already implemented it since you wrote:
You are right, pull requests can be opened here: https://github.com/quickfix-j/quickfixj/pulls I have added you to the developer group so you should be able to assign this task to yourself. Maybe a re-login is necessary. Cheers, |
| Comment by Wojciech Zankowski [ 29/Jul/19 ] |
|
Pull request created, to review: https://github.com/quickfix-j/quickfixj/pull/227 |
| Comment by Christoph John [ 29/Jul/19 ] |
|
Thanks, already commented there. Will assign you this ticket. |