[QFJ-960] Watermarks should not be activated when neither queue size nor watermarks are configured Created: 10/Nov/18  Updated: 11/Jan/19  Resolved: 12/Nov/18

Status: Closed
Project: QuickFIX/J
Component/s: None
Affects Version/s: 2.1.0
Fix Version/s: 2.1.1

Type: Bug Priority: Major
Reporter: Mr. Bald Assignee: Mr. Bald
Resolution: Fixed Votes: 0
Labels: None


 Description   

When creating an initiator or an acceptor (both synchronous and thread-per-session) without specifying either queue size or watermarks, the watermark tracker is still created and is working incorrectly immediately blocking the reads (queue size 0 is > upper watermark of -1).

Watermarks should only be activated when the queue size is not specified and both lower and upper watermarks are configured to values > 0.

Pull request (code change + tests) - https://github.com/quickfix-j/quickfixj/pull/213

 Comments   
Comment by Mr. Bald [ 10/Nov/18 ]

Christoph John - could you please check if it can be included into 2.2.0?

Comment by Christoph John [ 10/Nov/18 ]

Hi Mr. Bald,

thanks for the PR.
Just to understand the problem: this can only happen when using the Builder (and forgetting to set a watermark size) or when I pass 0 as watermark size into the constructor of the connector, right?

I am maybe considering releasing a 2.1.1 with this fix and the one from https://github.com/quickfix-j/quickfixj/pull/211 (QFJ-953).

Cheers,
Chris.

Comment by Mr. Bald [ 11/Nov/18 ]

Christoph John - correct, it happens when you either pass 0/-1. But also when you specify neither a queue nor watermarks (which must have been a valid use case before the watermarks introduction, which I broke it with the original watermarks change). Basically everything causing `EventHandlingStrategy(xxx, -1, -1)` or `EventHandlingStrategy(null, 0, 0)`. 2.1.1 - even better.

Generated at Mon May 13 01:41:14 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.