[QFJ-556]  ThreadedSocketAcceptor/DynamicAcceptorSessionProvider do not get checked by SessionTimerTask Created: 03/Sep/10  Updated: 01/Oct/17  Resolved: 01/Oct/17

Status: Closed
Project: QuickFIX/J
Component/s: Engine
Affects Version/s: 1.5.0
Fix Version/s: 1.5.1

Type: Bug Priority: Default
Reporter: Andre Mermegas Assignee: Unassigned
Resolution: Fixed Votes: 1
Labels: None

Issue Links:
Relates
relates to QFJ-609 Improve JMX session registration. Closed

 Description   

ThreadedSocketAcceptor/DynamicAcceptorSessionProvider Sessions do not get checked by SessionTimerTask because sessionconnector is always null from ThreadPerSessionEventHandlingStrategy.

DynamicAcceptorSessionProvider.getSession(...) {
if(sessionConnector != null) {
sessionConnector.addDynamicSession(s);
}
}

ThreadPerSessionEventHandlingStrategy.getSessionConnector() {
return null;
}

simple fix i tested was to just add the connector constructor like in SingleThread version

public ThreadPerSessionEventHandlingStrategy(SessionConnector connector)

{ sessionConnector = connector; }

 Comments   
Comment by Andre Mermegas [ 03/Sep/10 ]

and of course return the field instead of null
ThreadPerSessionEventHandlingStrategy {
....
public SessionConnector getSessionConnector()

{ return sessionConnector; }

....
}

updated constructor calls in
ThreadedSocketInitiator, ThreadedSocketAcceptor
private final ThreadPerSessionEventHandlingStrategy eventHandlingStrategy = new ThreadPerSessionEventHandlingStrategy(this);

Comment by Christoph John [ 01/Oct/17 ]

Fixed by QFJ-609.

Generated at Thu May 02 12:35:30 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.