[QFJ-526] Regression: QFJ-419 change forces ReconnectInterval to be in DEFAULT section Created: 16/May/10  Updated: 18/May/10  Resolved: 17/May/10

Status: Closed
Project: QuickFIX/J
Component/s: None
Affects Version/s: 1.5.0
Fix Version/s: 1.5.0

Type: Bug Priority: Default
Reporter: Scott Harrington Assignee: Unassigned
Resolution: Fixed Votes: 0
Labels: None


 Description   

I'm testing against the SVN trunk and one of my working configs failed with "ReconnectInterval not defined". This config has the ReconnectInterval defined only in the [SESSION] sections, and not in the [DEFAULT]. Simple one-line fix; see below.

Index: core/src/main/java/quickfix/DefaultSessionFactory.java
===================================================================
— core/src/main/java/quickfix/DefaultSessionFactory.java (revision 950)
+++ core/src/main/java/quickfix/DefaultSessionFactory.java (working copy)
@@ -306,7 +306,7 @@
private int[] getLogonIntervalsInSeconds(SessionSettings settings, SessionID sessionID) throws ConfigError {
if (settings.isSetting(sessionID, Initiator.SETTING_RECONNECT_INTERVAL)) {
try

{ - String raw = settings.getString(Initiator.SETTING_RECONNECT_INTERVAL); + String raw = settings.getString(sessionID, Initiator.SETTING_RECONNECT_INTERVAL); int[] ret = SessionSettings.parseSettingReconnectInterval(raw); if (ret != null) return ret; }

catch (Throwable e) {

 Comments   
Comment by Laurent Danesi [ 17/May/10 ]

Thank you Scott,

I have just re-committed the fix.

Laurent

Comment by Scott Harrington [ 17/May/10 ]

Hi Laurent: Unfortunately the same mistake was repeated in nearly identical code in AbstractSocketInitiator; not sure why I tripped over it in one place and not the other. Could you please fix this one also:

Index: core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java
===================================================================
— core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java (revision 950)
+++ core/src/main/java/quickfix/mina/initiator/AbstractSocketInitiator.java (working copy)
@@ -155,7 +155,7 @@
SessionSettings settings = getSettings();
if (settings.isSetting(sessionID, Initiator.SETTING_RECONNECT_INTERVAL)) {
try

{ - String raw = settings.getString(Initiator.SETTING_RECONNECT_INTERVAL); + String raw = settings.getString(sessionID, Initiator.SETTING_RECONNECT_INTERVAL); int[] ret = SessionSettings.parseSettingReconnectInterval(raw); if (ret != null) return ret; }

catch (Throwable e) {

Comment by Laurent Danesi [ 18/May/10 ]

The second part is in now.

Thank you

Generated at Mon May 06 22:40:27 UTC 2024 using JIRA 7.5.2#75007-sha1:9f5725bb824792b3230a5d8716f0c13e296a3cae.