I suggest the following patch :
- In quickfix.FileLog class, writeMessage(FileOutputStream stream, String message, boolean forceTimestamp) method:
- LogUtil.logThrowable(sessionID, "error writing message to log", e);*
+ e.printStackTrace();*
This should prevent StackOverflow error when an exception is raised while logging an exception.
I would also suggest:
- In quickfix.Session class isStateRefreshNeeded(String msgType) method :
- return refreshMessageStoreAtLogon && !state.isInitiator() && msgType.equals(MsgType.LOGON);
+ return refreshMessageStoreAtLogon && msgType.equals(MsgType.LOGON);
This will make sure MessageStore#refresh() is called on logon, so that in case of filesystem failure, file storing sequence numbers is reopen when trying to reconnect. By the way, I did not understood clearly why this method returns false when ConnectionType property is set to Initiator
Hello,
Do you need further information to fix this issue?
Best regards,
committed on integration branch rev 1018
It seems to me that the safest and simplest approach to avoiding the StackOverflow is to simply write the exception message, stack trace and session ID to the standard error stream. The modified code delegates the logging to the SLFJ logger but that logger may also be writing to the same removed file system. This will cause another exception which will be caught in the MINA-related code (when logging incoming messages). It's not clear to me if this will be another source of a StackOverflow or not or result in some other undesired behavior.
As discussed with Steve, it is safest to log the error to the standard error stream.
Committed on integration branch rev#1028.
A question related to this 'fix':
(FileLog.java
private void writeMessage(FileOutputStream stream, String message, boolean forceTimestamp) {
try {
if (forceTimestamp || includeTimestampForMessages)
stream.write(message.getBytes(CharsetSupport.getCharset()));
stream.write('\n');
stream.flush();
if (syncAfterWrite)
} catch (IOException e)
{ //QFJ-459: no point trying to log the error in the file if we had an IOException //we will end up with a java.lang.StackOverflowError System.err.println("error writing message to log : "+message); e.printStackTrace(System.err); }}
Why do you need to log this error? Why isn't it much-much better to throw an exception or at least call a callback registered by the application? This code can lead to the application not knowing about a possibly critical problem, i.e. qfix not being able to write to the log file stream.