Uploaded image for project: 'QuickFIX/J'
  1. QuickFIX/J
  2. QFJ-406

No way for FileStore to be closed

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Default
    • Resolution: Duplicate
    • Affects Version/s: 1.4.0
    • Fix Version/s: 1.5.0
    • Component/s: None
    • Labels:
      None
    • Environment:
      Windows XP sp3, Java 6

      Description

      If I create a ThreadedSocketInitiator with a FileStoreFactory, start, stop and re-start it, I get the following in stderr:

      File delete failed: ...\FIX.4.2-xxx.header
      File delete failed: ...\FIX.4.2-xxx.body
      File delete failed: ...\FIX.4.2-xxx.seqnums

      This seems to be because ThreadedSocketInitiator gets a new FileStore from FileStoreFactory which then locks files (for example - initializeMessageIndex opens a FileOutputStream for the header file).

      When I stop the initiator this FileStore is never closed - the FileStore doesn't actually have any kind of close or dispose method.

      When I restart the initiator it gets a new FileStore which barfs with the above errors when it can't delete the files.

      I'm happy to work up a patch for this but would appreciate some guidance as to what the commiters think should close the FileStore.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                jerryshea Jerry Shea
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: