Potential null pointer in DataDictionary.isMsgField

isMsgField uses single & after a null check - since & doesn't short circuit it throws null pointer if fields is null.

Change from:

public boolean isMsgField(String msgType, int field)

{ Set fields = (Set) messageFields.get(msgType); return fields != null & fields.contains(new Integer(field)); }

to

public boolean isMsgField(String msgType, int field)

{ Set fields = (Set) messageFields.get(msgType); return fields != null && fields.contains(new Integer(field)); }

Unit test - add the following to DataDictionaryTest.testDictionary()

assertFalse(dd.isMsgField("UNKNOWN_TYPE", 1));